vhost: log error for badly negotiated features
authorDariusz Stojaczyk <dariuszx.stojaczyk@intel.com>
Fri, 16 Jun 2017 14:32:05 +0000 (16:32 +0200)
committerYuanhan Liu <yliu@fridaylinux.org>
Fri, 16 Jun 2017 12:04:25 +0000 (14:04 +0200)
Since vhost_user_set_features failure is not handled in any way, a
single error log has been added to at least to let the user know that
something has gone wrong.

Signed-off-by: Dariusz Stojaczyk <dariuszx.stojaczyk@intel.com>
Acked-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
lib/librte_vhost/vhost_user.c

index e90b44c..ad2e8d3 100644 (file)
@@ -168,8 +168,12 @@ vhost_user_set_features(struct virtio_net *dev, uint64_t features)
        uint64_t vhost_features = 0;
 
        rte_vhost_driver_get_features(dev->ifname, &vhost_features);
-       if (features & ~vhost_features)
+       if (features & ~vhost_features) {
+               RTE_LOG(ERR, VHOST_CONFIG,
+                       "(%d) received invalid negotiated features.\n",
+                       dev->vid);
                return -1;
+       }
 
        if ((dev->flags & VIRTIO_DEV_RUNNING) && dev->features != features) {
                if (dev->notify_ops->features_changed)