vhost: fix missed unlock
authorHuawei Xie <huawei.xie@intel.com>
Thu, 10 Dec 2015 17:57:19 +0000 (01:57 +0800)
committerThomas Monjalon <thomas.monjalon@6wind.com>
Sun, 13 Dec 2015 01:13:39 +0000 (02:13 +0100)
CID 107113 (#1 of 1): Missing unlock (LOCK)5. missing_unlock: Returning
without unlocking pfdset->fd_mutex.
Fixes: fbf7e07ca142 ("vhost: add select based event driven processing")

Signed-off-by: Huawei Xie <huawei.xie@intel.com>
Acked-by: John McNamara <john.mcnamara@intel.com>
lib/librte_vhost/vhost_user/fd_man.c

index d68b270..087aaed 100644 (file)
@@ -150,8 +150,10 @@ fdset_add(struct fdset *pfdset, int fd, fd_cb rcb, fd_cb wcb, void *dat)
 
        /* Find a free slot in the list. */
        i = fdset_find_free_slot(pfdset);
-       if (i == -1)
+       if (i == -1) {
+               pthread_mutex_unlock(&pfdset->fd_mutex);
                return -2;
+       }
 
        fdset_add_fd(pfdset, i, fd, rcb, wcb, dat);
        pfdset->num++;