net/i40e: fix return code not checked
authorDaniel Mrzyglod <danielx.t.mrzyglod@intel.com>
Thu, 10 Aug 2017 09:12:14 +0000 (11:12 +0200)
committerFerruh Yigit <ferruh.yigit@intel.com>
Fri, 6 Oct 2017 00:49:47 +0000 (02:49 +0200)
Calling i40e_vsi_delete_mac without checking return
value (as is done elsewhere 5 out of 6 times)

Coverity issue: 140735
Fixes: 43c89d5a4fde ("net/i40e: set VF MAC from PF")

Signed-off-by: Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
drivers/net/i40e/rte_pmd_i40e.c

index f12b7f4..950a0d6 100644 (file)
@@ -591,7 +591,9 @@ rte_pmd_i40e_set_vf_mac_addr(uint8_t port, uint16_t vf_id,
 
        /* Remove all existing mac */
        TAILQ_FOREACH_SAFE(f, &vsi->mac_list, next, temp)
-               i40e_vsi_delete_mac(vsi, &f->mac_info.mac_addr);
+               if (i40e_vsi_delete_mac(vsi, &f->mac_info.mac_addr)
+                               != I40E_SUCCESS)
+                       PMD_DRV_LOG(WARNING, "Delete MAC failed");
 
        return 0;
 }