vhost: comment unwanted callback
authorHuawei Xie <huawei.xie@intel.com>
Tue, 30 Jun 2015 09:20:50 +0000 (17:20 +0800)
committerThomas Monjalon <thomas.monjalon@6wind.com>
Tue, 30 Jun 2015 15:49:08 +0000 (17:49 +0200)
add comment for potential unwanted callback on listenfds

Signed-off-by: Huawei Xie <huawei.xie@intel.com>
lib/librte_vhost/vhost_user/fd_man.c

index bd30f8d..d68b270 100644 (file)
@@ -242,6 +242,13 @@ fdset_event_dispatch(struct fdset *pfdset)
 
                pthread_mutex_unlock(&pfdset->fd_mutex);
 
+               /*
+                * When select is blocked, other threads might unregister
+                * listenfds from and register new listenfds into fdset.
+                * When select returns, the entries for listenfds in the fdset
+                * might have been updated. It is ok if there is unwanted call
+                * for new listenfds.
+                */
                ret = select(maxfds + 1, &rfds, &wfds, NULL, &tv);
                if (ret <= 0)
                        continue;