af_packet: fix possible memory leak
authorDaniel Mrzyglod <danielx.t.mrzyglod@intel.com>
Fri, 19 Dec 2014 15:01:36 +0000 (16:01 +0100)
committerThomas Monjalon <thomas.monjalon@6wind.com>
Fri, 19 Dec 2014 22:30:25 +0000 (23:30 +0100)
In rte_pmd_init_internals, we are mapping memory but not released
if error occurs it could produce memory leak.
Add unmmap function to release memory.

Signed-off-by: Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>
Acked-by: Michal Jastrzebski <michalx.k.jastrzebski@intel.com>
Acked-by: John W. Linville <linville@tuxdriver.com>
lib/librte_pmd_af_packet/rte_eth_af_packet.c

index 236749b..755780a 100644 (file)
@@ -481,6 +481,11 @@ rte_pmd_init_internals(const char *name,
        if (*internals == NULL)
                goto error;
 
+       for (q = 0; q < nb_queues; q++) {
+               (*internals)->rx_queue[q].map = MAP_FAILED;
+               (*internals)->tx_queue[q].map = MAP_FAILED;
+       }
+
        req = &((*internals)->req);
 
        req->tp_block_size = blocksize;
@@ -682,6 +687,8 @@ error:
                rte_free(pci_dev);
        if (*internals) {
                for (q = 0; q < nb_queues; q++) {
+                       munmap((*internals)->rx_queue[q].map,
+                              2 * req->tp_block_size * req->tp_block_nr);
                        if ((*internals)->rx_queue[q].rd)
                                rte_free((*internals)->rx_queue[q].rd);
                        if ((*internals)->tx_queue[q].rd)