net/mlx5: fix UDP checksum zeroing
authorDekel Peled <dekelp@mellanox.com>
Mon, 5 Aug 2019 11:51:19 +0000 (14:51 +0300)
committerRaslan Darawsheh <rasland@mellanox.com>
Tue, 6 Aug 2019 15:42:12 +0000 (17:42 +0200)
Function flow_dv_zero_encap_udp_csum() uses a while loop to iterate
over vlan items in flow rule.
Pointer next_hdr is incremented to the next item before it is used,
so the first item is skipped.

This patch moves the incrementing of next_hdr to the correct place.

Fixes: bf1d7d9a033a ("net/mlx5: zero out UDP checksum in encapsulation")

Signed-off-by: Dekel Peled <dekelp@mellanox.com>
Acked-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
drivers/net/mlx5/mlx5_flow_dv.c

index a7d677f..ca7252a 100644 (file)
@@ -1504,9 +1504,9 @@ flow_dv_zero_encap_udp_csum(void *data, struct rte_flow_error *error)
 
        /* VLAN skipping */
        while (proto == RTE_ETHER_TYPE_VLAN || proto == RTE_ETHER_TYPE_QINQ) {
-               next_hdr += sizeof(struct rte_vlan_hdr);
                vlan = (struct rte_vlan_hdr *)next_hdr;
                proto = RTE_BE16(vlan->eth_proto);
+               next_hdr += sizeof(struct rte_vlan_hdr);
        }
 
        /* HW calculates IPv4 csum. no need to proceed */