buildtools: check allocation error in pmdinfogen
authorYong Wang <wang.yong19@zte.com.cn>
Fri, 15 Sep 2017 11:33:08 +0000 (07:33 -0400)
committerThomas Monjalon <thomas@monjalon.net>
Tue, 7 Nov 2017 22:24:43 +0000 (23:24 +0100)
In func locate_pmd_entries(), pointer 'new' returned from call to func
'calloc' may be NULL. It is dereferenced without null point check.

Signed-off-by: Yong Wang <wang.yong19@zte.com.cn>
buildtools/pmdinfogen/pmdinfogen.c

index e73fc76..96ccbf3 100644 (file)
@@ -327,6 +327,10 @@ static int locate_pmd_entries(struct elf_info *info)
 
        do {
                new = calloc(sizeof(struct pmd_driver), 1);
+               if (new == NULL) {
+                       fprintf(stderr, "Failed to calloc memory\n");
+                       return -1;
+               }
                new->name_sym = find_sym_in_symtab(info, "this_pmd_name", last);
                last = new->name_sym;
                if (!new->name_sym)
@@ -408,7 +412,8 @@ int main(int argc, char **argv)
        }
        parse_elf(&info, argv[1]);
 
-       locate_pmd_entries(&info);
+       if (locate_pmd_entries(&info) < 0)
+               exit(1);
 
        if (info.drivers) {
                output_pmd_info_string(&info, argv[2]);