compress/mlx5: fix double close of device context
authorMichael Baum <michaelba@nvidia.com>
Thu, 25 Nov 2021 08:18:29 +0000 (10:18 +0200)
committerAkhil Goyal <gakhil@marvell.com>
Thu, 25 Nov 2021 10:16:56 +0000 (11:16 +0100)
The context of the device opens once in the common probe and closes with
its removal.

If the probe of one of the drivers fails, it releases its resources and
then the common closes the context.
But mistakenly in the compress probe, if there isn't enough capabilities
to support compress operations, it closes the device and then common
probe closes it again.

Remove the redundant closing from compress probe.

Fixes: 2efd26544554 ("compress/mlx5: support partial transformation")
Cc: stable@dpdk.org
Signed-off-by: Michael Baum <michaelba@nvidia.com>
Acked-by: Matan Azrad <matan@nvidia.com>
drivers/compress/mlx5/mlx5_compress.c

index bb0dc3a..82b871b 100644 (file)
@@ -723,7 +723,6 @@ mlx5_compress_dev_probe(struct mlx5_common_device *cdev)
                && !attr->mmo_compress_qp_en && !attr->mmo_compress_sq_en
                && !attr->mmo_dma_qp_en && !attr->mmo_dma_sq_en) {
                DRV_LOG(ERR, "Not enough capabilities to support compress operations, maybe old FW/OFED version?");
-               claim_zero(mlx5_glue->close_device(cdev->ctx));
                rte_errno = ENOTSUP;
                return -ENOTSUP;
        }