eal/linux: use strlcpy in uevent parsing
authorThomas Monjalon <thomas@monjalon.net>
Tue, 17 Apr 2018 12:23:29 +0000 (14:23 +0200)
committerThomas Monjalon <thomas@monjalon.net>
Mon, 23 Apr 2018 14:23:15 +0000 (16:23 +0200)
Support of strlcpy has recently been added to DPDK.

This replacement has been generated by the coccinelle script:
devtools/cocci.sh devtools/cocci/strlcpy.cocci

Fixes: 0d0f478d0483 ("eal/linux: add uevent parse and process")

Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
lib/librte_eal/linuxapp/eal/eal_dev.c

index 9478a39..1cf6aeb 100644 (file)
@@ -7,6 +7,7 @@
 #include <sys/socket.h>
 #include <linux/netlink.h>
 
+#include <rte_string_fns.h>
 #include <rte_log.h>
 #include <rte_compat.h>
 #include <rte_dev.h>
@@ -94,15 +95,15 @@ dev_uev_parse(const char *buf, struct rte_dev_event *event, int length)
                if (!strncmp(buf, "ACTION=", 7)) {
                        buf += 7;
                        i += 7;
-                       snprintf(action, sizeof(action), "%s", buf);
+                       strlcpy(action, buf, sizeof(action));
                } else if (!strncmp(buf, "SUBSYSTEM=", 10)) {
                        buf += 10;
                        i += 10;
-                       snprintf(subsystem, sizeof(subsystem), "%s", buf);
+                       strlcpy(subsystem, buf, sizeof(subsystem));
                } else if (!strncmp(buf, "PCI_SLOT_NAME=", 14)) {
                        buf += 14;
                        i += 14;
-                       snprintf(pci_slot_name, sizeof(subsystem), "%s", buf);
+                       strlcpy(pci_slot_name, buf, sizeof(subsystem));
                        event->devname = strdup(pci_slot_name);
                }
                for (; i < length; i++) {