app/bbdev: fix null termination in argument parsing
authorAmr Mokhtar <amr.mokhtar@intel.com>
Wed, 31 Jan 2018 12:40:40 +0000 (12:40 +0000)
committerThomas Monjalon <thomas@monjalon.net>
Wed, 31 Jan 2018 17:40:36 +0000 (18:40 +0100)
use snprintf instead of strncpy to ensure null termination when
copying test_vector_filename from cmd arguments.

Coverity issue: 257001
Fixes: f714a18885a6 ("app/testbbdev: add test application for bbdev")

Signed-off-by: Amr Mokhtar <amr.mokhtar@intel.com>
app/test-bbdev/main.c

index 3f542a8..41b54bb 100644 (file)
@@ -226,8 +226,9 @@ parse_args(int argc, char **argv, struct test_params *tp)
                        TEST_ASSERT(strlen(optarg) > 0,
                                        "Config file name is null");
 
-                       strncpy(tp->test_vector_filename, optarg,
-                                       sizeof(tp->test_vector_filename));
+                       snprintf(tp->test_vector_filename,
+                                       sizeof(tp->test_vector_filename),
+                                       "%s", optarg);
                        break;
                case 'l':
                        TEST_ASSERT(strlen(optarg) > 0,