net/mlx5: add meter ASO queue management
authorLi Zhang <lizh@nvidia.com>
Tue, 20 Apr 2021 10:55:18 +0000 (13:55 +0300)
committerRaslan Darawsheh <rasland@nvidia.com>
Wed, 21 Apr 2021 06:28:05 +0000 (08:28 +0200)
This patch adds the ASO queue management for flow meter,
includes send WQE and CQE handle functions.

Signed-off-by: Li Zhang <lizh@nvidia.com>
Acked-by: Matan Azrad <matan@nvidia.com>
drivers/net/mlx5/mlx5.h
drivers/net/mlx5/mlx5_flow_aso.c
drivers/net/mlx5/mlx5_flow_meter.c

index 4ad0e14..adf24f0 100644 (file)
@@ -1540,5 +1540,9 @@ int mlx5_aso_flow_hit_queue_poll_start(struct mlx5_dev_ctx_shared *sh);
 int mlx5_aso_flow_hit_queue_poll_stop(struct mlx5_dev_ctx_shared *sh);
 void mlx5_aso_queue_uninit(struct mlx5_dev_ctx_shared *sh,
                enum mlx5_access_aso_opc_mod aso_opc_mod);
+int mlx5_aso_meter_update_by_wqe(struct mlx5_dev_ctx_shared *sh,
+               struct mlx5_aso_mtr *mtr);
+int mlx5_aso_mtr_wait(struct mlx5_dev_ctx_shared *sh,
+               struct mlx5_aso_mtr *mtr);
 
 #endif /* RTE_PMD_MLX5_H_ */
index 067471b..fe5c991 100644 (file)
@@ -13,7 +13,6 @@
 #include "mlx5.h"
 #include "mlx5_flow.h"
 
-
 /**
  * Destroy Completion Queue used for ASO access.
  *
@@ -657,3 +656,185 @@ mlx5_aso_flow_hit_queue_poll_stop(struct mlx5_dev_ctx_shared *sh)
        }
        return -rte_errno;
 }
+
+static uint16_t
+mlx5_aso_mtr_sq_enqueue_single(struct mlx5_aso_sq *sq,
+               struct mlx5_aso_mtr *aso_mtr)
+{
+       volatile struct mlx5_aso_wqe *wqe = NULL;
+       struct mlx5_flow_meter_info *fm = NULL;
+       uint16_t size = 1 << sq->log_desc_n;
+       uint16_t mask = size - 1;
+       uint16_t res = size - (uint16_t)(sq->head - sq->tail);
+       uint32_t dseg_idx = 0;
+       struct mlx5_aso_mtr_pool *pool = NULL;
+
+       if (unlikely(!res)) {
+               DRV_LOG(ERR, "Fail: SQ is full and no free WQE to send");
+               return 0;
+       }
+       wqe = &sq->sq_obj.aso_wqes[sq->head & mask];
+       rte_prefetch0(&sq->sq_obj.aso_wqes[(sq->head + 1) & mask]);
+       /* Fill next WQE. */
+       fm = &aso_mtr->fm;
+       sq->elts[sq->head & mask].mtr = aso_mtr;
+       pool = container_of(aso_mtr, struct mlx5_aso_mtr_pool,
+                       mtrs[aso_mtr->offset]);
+       wqe->general_cseg.misc = rte_cpu_to_be_32(pool->devx_obj->id +
+                       (aso_mtr->offset >> 1));
+       wqe->general_cseg.opcode = rte_cpu_to_be_32(MLX5_OPCODE_ACCESS_ASO |
+                       (ASO_OPC_MOD_POLICER <<
+                       WQE_CSEG_OPC_MOD_OFFSET) |
+                       sq->pi << WQE_CSEG_WQE_INDEX_OFFSET);
+       /* There are 2 meters in one ASO cache line. */
+       dseg_idx = aso_mtr->offset & 0x1;
+       wqe->aso_cseg.data_mask =
+               RTE_BE64(MLX5_IFC_FLOW_METER_PARAM_MASK << (32 * !dseg_idx));
+       if (fm->is_enable) {
+               wqe->aso_dseg.mtrs[dseg_idx].cbs_cir =
+                       fm->profile->srtcm_prm.cbs_cir;
+               wqe->aso_dseg.mtrs[dseg_idx].ebs_eir =
+                       fm->profile->srtcm_prm.ebs_eir;
+       } else {
+               wqe->aso_dseg.mtrs[dseg_idx].cbs_cir =
+                       RTE_BE32(MLX5_IFC_FLOW_METER_DISABLE_CBS_CIR_VAL);
+               wqe->aso_dseg.mtrs[dseg_idx].ebs_eir = 0;
+       }
+       sq->head++;
+       sq->pi += 2;/* Each WQE contains 2 WQEBB's. */
+       rte_io_wmb();
+       sq->sq_obj.db_rec[MLX5_SND_DBR] = rte_cpu_to_be_32(sq->pi);
+       rte_wmb();
+       *sq->uar_addr = *(volatile uint64_t *)wqe; /* Assume 64 bit ARCH. */
+       rte_wmb();
+       return 1;
+}
+
+static void
+mlx5_aso_mtrs_status_update(struct mlx5_aso_sq *sq, uint16_t aso_mtrs_nums)
+{
+       uint16_t size = 1 << sq->log_desc_n;
+       uint16_t mask = size - 1;
+       uint16_t i;
+       struct mlx5_aso_mtr *aso_mtr = NULL;
+       uint8_t exp_state = ASO_METER_WAIT;
+
+       for (i = 0; i < aso_mtrs_nums; ++i) {
+               aso_mtr = sq->elts[(sq->tail + i) & mask].mtr;
+               MLX5_ASSERT(aso_mtr);
+               (void)__atomic_compare_exchange_n(&aso_mtr->state,
+                               &exp_state, ASO_METER_READY,
+                               false, __ATOMIC_RELAXED, __ATOMIC_RELAXED);
+       }
+}
+
+static void
+mlx5_aso_mtr_completion_handle(struct mlx5_aso_sq *sq)
+{
+       struct mlx5_aso_cq *cq = &sq->cq;
+       volatile struct mlx5_cqe *restrict cqe;
+       const unsigned int cq_size = 1 << cq->log_desc_n;
+       const unsigned int mask = cq_size - 1;
+       uint32_t idx;
+       uint32_t next_idx = cq->cq_ci & mask;
+       const uint16_t max = (uint16_t)(sq->head - sq->tail);
+       uint16_t n = 0;
+       int ret;
+
+       if (unlikely(!max))
+               return;
+       do {
+               idx = next_idx;
+               next_idx = (cq->cq_ci + 1) & mask;
+               rte_prefetch0(&cq->cq_obj.cqes[next_idx]);
+               cqe = &cq->cq_obj.cqes[idx];
+               ret = check_cqe(cqe, cq_size, cq->cq_ci);
+               /*
+                * Be sure owner read is done before any other cookie field or
+                * opaque field.
+                */
+               rte_io_rmb();
+               if (ret != MLX5_CQE_STATUS_SW_OWN) {
+                       if (likely(ret == MLX5_CQE_STATUS_HW_OWN))
+                               break;
+                       mlx5_aso_cqe_err_handle(sq);
+               } else {
+                       n++;
+               }
+               cq->cq_ci++;
+       } while (1);
+       if (likely(n)) {
+               mlx5_aso_mtrs_status_update(sq, n);
+               sq->tail += n;
+               rte_io_wmb();
+               cq->cq_obj.db_rec[0] = rte_cpu_to_be_32(cq->cq_ci);
+       }
+}
+
+/**
+ * Update meter parameter by send WQE.
+ *
+ * @param[in] dev
+ *   Pointer to Ethernet device.
+ * @param[in] priv
+ *   Pointer to mlx5 private data structure.
+ * @param[in] fm
+ *   Pointer to flow meter to be modified.
+ *
+ * @return
+ *   0 on success, a negative errno value otherwise and rte_errno is set.
+ */
+int
+mlx5_aso_meter_update_by_wqe(struct mlx5_dev_ctx_shared *sh,
+                       struct mlx5_aso_mtr *mtr)
+{
+       struct mlx5_aso_sq *sq = &sh->mtrmng->sq;
+       uint32_t poll_wqe_times = MLX5_MTR_POLL_WQE_CQE_TIMES;
+
+       do {
+               mlx5_aso_mtr_completion_handle(sq);
+               if (mlx5_aso_mtr_sq_enqueue_single(sq, mtr))
+                       return 0;
+               /* Waiting for wqe resource. */
+               rte_delay_us_sleep(MLX5_ASO_WQE_CQE_RESPONSE_DELAY);
+       } while (--poll_wqe_times);
+       DRV_LOG(ERR, "Fail to send WQE for ASO meter %d",
+                       mtr->fm.meter_id);
+       return -1;
+}
+
+/**
+ * Wait for meter to be ready.
+ *
+ * @param[in] dev
+ *   Pointer to Ethernet device.
+ * @param[in] priv
+ *   Pointer to mlx5 private data structure.
+ * @param[in] fm
+ *   Pointer to flow meter to be modified.
+ *
+ * @return
+ *   0 on success, a negative errno value otherwise and rte_errno is set.
+ */
+int
+mlx5_aso_mtr_wait(struct mlx5_dev_ctx_shared *sh,
+                       struct mlx5_aso_mtr *mtr)
+{
+       struct mlx5_aso_sq *sq = &sh->mtrmng->sq;
+       uint32_t poll_cqe_times = MLX5_MTR_POLL_WQE_CQE_TIMES;
+
+       if (__atomic_load_n(&mtr->state, __ATOMIC_RELAXED) ==
+                                           ASO_METER_READY)
+               return 0;
+       do {
+               mlx5_aso_mtr_completion_handle(sq);
+               if (__atomic_load_n(&mtr->state, __ATOMIC_RELAXED) ==
+                                           ASO_METER_READY)
+                       return 0;
+               /* Waiting for CQE ready. */
+               rte_delay_us_sleep(MLX5_ASO_WQE_CQE_RESPONSE_DELAY);
+       } while (--poll_cqe_times);
+       DRV_LOG(ERR, "Fail to poll CQE ready for ASO meter %d",
+                       mtr->fm.meter_id);
+       return -1;
+}
index ef4ca30..fcefc13 100644 (file)
@@ -540,56 +540,79 @@ static int
 mlx5_flow_meter_action_modify(struct mlx5_priv *priv,
                struct mlx5_flow_meter_info *fm,
                const struct mlx5_flow_meter_srtcm_rfc2697_prm *srtcm,
-               uint64_t modify_bits, uint32_t active_state)
+               uint64_t modify_bits, uint32_t active_state, uint32_t is_enable)
 {
 #ifdef HAVE_MLX5_DR_CREATE_ACTION_FLOW_METER
        uint32_t in[MLX5_ST_SZ_DW(flow_meter_parameters)] = { 0 };
        uint32_t *attr;
        struct mlx5dv_dr_flow_meter_attr mod_attr = { 0 };
        int ret;
+       struct mlx5_aso_mtr *aso_mtr = NULL;
        uint32_t cbs_cir, ebs_eir, val;
 
-       /* Fill command parameters. */
-       mod_attr.reg_c_index = priv->mtr_color_reg - REG_C_0;
-       mod_attr.flow_meter_parameter = in;
-       mod_attr.flow_meter_parameter_sz =
+       if (priv->sh->meter_aso_en) {
+               fm->is_enable = !!is_enable;
+               aso_mtr = container_of(fm, struct mlx5_aso_mtr, fm);
+               ret = mlx5_aso_meter_update_by_wqe(priv->sh, aso_mtr);
+               if (ret)
+                       return ret;
+               ret = mlx5_aso_mtr_wait(priv->sh, aso_mtr);
+               if (ret)
+                       return ret;
+       } else {
+               /* Fill command parameters. */
+               mod_attr.reg_c_index = priv->mtr_color_reg - REG_C_0;
+               mod_attr.flow_meter_parameter = in;
+               mod_attr.flow_meter_parameter_sz =
                                MLX5_ST_SZ_BYTES(flow_meter_parameters);
-       if (modify_bits & MLX5_FLOW_METER_OBJ_MODIFY_FIELD_ACTIVE)
-               mod_attr.active = !!active_state;
-       else
-               mod_attr.active = 0;
-       attr = in;
-       cbs_cir = rte_be_to_cpu_32(srtcm->cbs_cir);
-       ebs_eir = rte_be_to_cpu_32(srtcm->ebs_eir);
-       if (modify_bits & MLX5_FLOW_METER_OBJ_MODIFY_FIELD_CBS) {
-               val = (cbs_cir >> ASO_DSEG_CBS_EXP_OFFSET) & ASO_DSEG_EXP_MASK;
-               MLX5_SET(flow_meter_parameters, attr, cbs_exponent, val);
-               val = (cbs_cir >> ASO_DSEG_CBS_MAN_OFFSET) & ASO_DSEG_MAN_MASK;
-               MLX5_SET(flow_meter_parameters, attr, cbs_mantissa, val);
-       }
-       if (modify_bits & MLX5_FLOW_METER_OBJ_MODIFY_FIELD_CIR) {
-               val = (cbs_cir >> ASO_DSEG_CIR_EXP_OFFSET) & ASO_DSEG_EXP_MASK;
-               MLX5_SET(flow_meter_parameters, attr, cir_exponent, val);
-               val = cbs_cir & ASO_DSEG_MAN_MASK;
-               MLX5_SET(flow_meter_parameters, attr, cir_mantissa, val);
-       }
-       if (modify_bits & MLX5_FLOW_METER_OBJ_MODIFY_FIELD_EBS) {
-               val = (ebs_eir >> ASO_DSEG_EBS_EXP_OFFSET) & ASO_DSEG_EXP_MASK;
-               MLX5_SET(flow_meter_parameters, attr, ebs_exponent, val);
-               val = (ebs_eir >> ASO_DSEG_EBS_MAN_OFFSET) & ASO_DSEG_MAN_MASK;
-               MLX5_SET(flow_meter_parameters, attr, ebs_mantissa, val);
-       }
-       /* Apply modifications to meter only if it was created. */
-       if (fm->mfts->meter_action) {
-               ret = mlx5_glue->dv_modify_flow_action_meter
+               if (modify_bits & MLX5_FLOW_METER_OBJ_MODIFY_FIELD_ACTIVE)
+                       mod_attr.active = !!active_state;
+               else
+                       mod_attr.active = 0;
+               attr = in;
+               cbs_cir = rte_be_to_cpu_32(srtcm->cbs_cir);
+               ebs_eir = rte_be_to_cpu_32(srtcm->ebs_eir);
+               if (modify_bits & MLX5_FLOW_METER_OBJ_MODIFY_FIELD_CBS) {
+                       val = (cbs_cir >> ASO_DSEG_CBS_EXP_OFFSET) &
+                               ASO_DSEG_EXP_MASK;
+                       MLX5_SET(flow_meter_parameters, attr,
+                               cbs_exponent, val);
+                       val = (cbs_cir >> ASO_DSEG_CBS_MAN_OFFSET) &
+                               ASO_DSEG_MAN_MASK;
+                       MLX5_SET(flow_meter_parameters, attr,
+                               cbs_mantissa, val);
+               }
+               if (modify_bits & MLX5_FLOW_METER_OBJ_MODIFY_FIELD_CIR) {
+                       val = (cbs_cir >> ASO_DSEG_CIR_EXP_OFFSET) &
+                               ASO_DSEG_EXP_MASK;
+                       MLX5_SET(flow_meter_parameters, attr,
+                               cir_exponent, val);
+                       val = cbs_cir & ASO_DSEG_MAN_MASK;
+                       MLX5_SET(flow_meter_parameters, attr,
+                               cir_mantissa, val);
+               }
+               if (modify_bits & MLX5_FLOW_METER_OBJ_MODIFY_FIELD_EBS) {
+                       val = (ebs_eir >> ASO_DSEG_EBS_EXP_OFFSET) &
+                               ASO_DSEG_EXP_MASK;
+                       MLX5_SET(flow_meter_parameters, attr,
+                               ebs_exponent, val);
+                       val = (ebs_eir >> ASO_DSEG_EBS_MAN_OFFSET) &
+                               ASO_DSEG_MAN_MASK;
+                       MLX5_SET(flow_meter_parameters, attr,
+                               ebs_mantissa, val);
+               }
+               /* Apply modifications to meter only if it was created. */
+               if (fm->mfts->meter_action) {
+                       ret = mlx5_glue->dv_modify_flow_action_meter
                                        (fm->mfts->meter_action, &mod_attr,
                                        rte_cpu_to_be_64(modify_bits));
-               if (ret)
-                       return ret;
+                       if (ret)
+                               return ret;
+               }
+               /* Update succeedded modify meter parameters. */
+               if (modify_bits & MLX5_FLOW_METER_OBJ_MODIFY_FIELD_ACTIVE)
+                       fm->active_state = !!active_state;
        }
-       /* Update succeedded modify meter parameters. */
-       if (modify_bits & MLX5_FLOW_METER_OBJ_MODIFY_FIELD_ACTIVE)
-               fm->active_state = !!active_state;
        return 0;
 #else
        (void)priv;
@@ -653,6 +676,7 @@ mlx5_flow_meter_create(struct rte_eth_dev *dev, uint32_t meter_id,
                .type = "mlx5_flow_mtr_flow_id_pool",
        };
        struct mlx5_aso_mtr *aso_mtr;
+       union mlx5_l3t_data data;
        uint32_t mtr_idx;
        int ret;
        uint8_t mtr_id_bits;
@@ -704,7 +728,6 @@ mlx5_flow_meter_create(struct rte_eth_dev *dev, uint32_t meter_id,
        fm->profile = fmp;
        memcpy(fm->action, params->action, sizeof(params->action));
        mlx5_flow_meter_stats_enable_update(fm, params->stats_mask);
-
        /* Alloc policer counters. */
        if (fm->green_bytes || fm->green_pkts) {
                fm->policer_stats.pass_cnt = mlx5_counter_alloc(dev);
@@ -727,12 +750,23 @@ mlx5_flow_meter_create(struct rte_eth_dev *dev, uint32_t meter_id,
        if (!priv->sh->meter_aso_en)
                TAILQ_INSERT_TAIL(fms, legacy_fm, next);
        fm->active_state = 1; /* Config meter starts as active. */
+       fm->is_enable = 1;
        fm->shared = !!shared;
        __atomic_add_fetch(&fm->profile->ref_cnt, 1, __ATOMIC_RELAXED);
        fm->flow_ipool = mlx5_ipool_create(&flow_ipool_cfg);
        if (!fm->flow_ipool)
                goto error;
        rte_spinlock_init(&fm->sl);
+       /* If ASO meter supported, allocate ASO flow meter. */
+       if (priv->sh->meter_aso_en) {
+               aso_mtr = container_of(fm, struct mlx5_aso_mtr, fm);
+               ret = mlx5_aso_meter_update_by_wqe(priv->sh, aso_mtr);
+               if (ret)
+                       goto error;
+               data.dword = mtr_idx;
+               if (mlx5_l3t_set_entry(priv->mtr_idx_tbl, meter_id, &data))
+                       goto error;
+       }
        return 0;
 error:
        mlx5_flow_destroy_policer_rules(dev, fm, &attr);
@@ -878,12 +912,12 @@ mlx5_flow_meter_modify_state(struct mlx5_priv *priv,
        int ret;
 
        if (new_state == MLX5_FLOW_METER_DISABLE)
-               ret = mlx5_flow_meter_action_modify(priv, fm, &srtcm,
-                                                   modify_bits, 0);
+               ret = mlx5_flow_meter_action_modify(priv, fm,
+                               &srtcm, modify_bits, 0, 0);
        else
                ret = mlx5_flow_meter_action_modify(priv, fm,
                                                   &fm->profile->srtcm_prm,
-                                                   modify_bits, 0);
+                                                   modify_bits, 0, 1);
        if (ret)
                return -rte_mtr_error_set(error, -ret,
                                          RTE_MTR_ERROR_TYPE_MTR_PARAMS,
@@ -1031,7 +1065,7 @@ mlx5_flow_meter_profile_update(struct rte_eth_dev *dev,
        if (fm->active_state == MLX5_FLOW_METER_DISABLE)
                return 0;
        ret = mlx5_flow_meter_action_modify(priv, fm, &fm->profile->srtcm_prm,
-                                             modify_bits, fm->active_state);
+                                             modify_bits, fm->active_state, 1);
        if (ret) {
                fm->profile = old_fmp;
                return -rte_mtr_error_set(error, -ret,
@@ -1281,6 +1315,8 @@ mlx5_flow_meter_ops_get(struct rte_eth_dev *dev __rte_unused, void *arg)
  *   Pointer to mlx5_priv.
  * @param meter_id
  *   Meter id.
+ * @param mtr_idx
+ *   Pointer to Meter index.
  *
  * @return
  *   Pointer to the profile found on success, NULL otherwise.
@@ -1297,10 +1333,6 @@ mlx5_flow_meter_find(struct mlx5_priv *priv, uint32_t meter_id,
 
        if (priv->sh->meter_aso_en) {
                rte_spinlock_lock(&mtrmng->mtrsl);
-               if (!mtrmng->n_valid) {
-                       rte_spinlock_unlock(&mtrmng->mtrsl);
-                       return NULL;
-               }
                if (mlx5_l3t_get_entry(priv->mtr_idx_tbl, meter_id, &data) ||
                        !data.dword) {
                        rte_spinlock_unlock(&mtrmng->mtrsl);
@@ -1309,17 +1341,18 @@ mlx5_flow_meter_find(struct mlx5_priv *priv, uint32_t meter_id,
                if (mtr_idx)
                        *mtr_idx = data.dword;
                aso_mtr = mlx5_aso_meter_by_idx(priv, data.dword);
+               /* Remove reference taken by the mlx5_l3t_get_entry. */
                mlx5_l3t_clear_entry(priv->mtr_idx_tbl, meter_id);
-               if (meter_id == aso_mtr->fm.meter_id) {
-                       rte_spinlock_unlock(&mtrmng->mtrsl);
-                       return &aso_mtr->fm;
-               }
+               MLX5_ASSERT(meter_id == aso_mtr->fm.meter_id);
                rte_spinlock_unlock(&mtrmng->mtrsl);
-       } else {
-               TAILQ_FOREACH(legacy_fm, fms, next)
-                       if (meter_id == legacy_fm->fm.meter_id)
-                               return &legacy_fm->fm;
+               return &aso_mtr->fm;
        }
+       TAILQ_FOREACH(legacy_fm, fms, next)
+               if (meter_id == legacy_fm->fm.meter_id) {
+                       if (mtr_idx)
+                               *mtr_idx = legacy_fm->idx;
+                       return &legacy_fm->fm;
+               }
        return NULL;
 }